| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrey Borodin <amborodin86(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Something is wrong with wal_compression |
| Date: | 2023-01-26 22:14:45 |
| Message-ID: | 3218320.1674771285@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrey Borodin <amborodin86(at)gmail(dot)com> writes:
> On Thu, Jan 26, 2023 at 12:12 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> That test case is demonstrating fundamental
>> database corruption after a crash.
> Not exactly corruption. XID was not persisted and buffer data did not
> hit a disk. Database is in the correct state.
Really? I don't see how this part is even a little bit okay:
[00:40:50.744](0.046s) not ok 3 - xid is aborted after crash
[00:40:50.745](0.001s)
[00:40:50.745](0.000s) # Failed test 'xid is aborted after crash'
# at t/011_crash_recovery.pl line 57.
[00:40:50.746](0.001s) # got: 'committed'
# expected: 'aborted'
If any tuples made by that transaction had reached disk,
we'd have a problem.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-01-26 22:37:05 | Re: suppressing useless wakeups in logical/worker.c |
| Previous Message | Nathan Bossart | 2023-01-26 22:02:53 | Re: improving user.c error messages |