| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, "Masashi Kamura (Fujitsu)" <kamura(dot)masashi(at)fujitsu(dot)com>, "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com> |
| Subject: | Re: Crash issue in PG18.5 regression |
| Date: | 2026-08-11 18:26:02 |
| Message-ID: | 3217de2d-2c7b-4ef2-ac9a-3958d62c78c0@iki.fi |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/08/2026 20:02, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> On 2026-08-11 12:41:49 +0300, Heikki Linnakangas wrote:
>>> Like the attached.
>
>> I wonder if we also ought to do something about the other uses of
>> pg_locale_t->info.lt in pg_locale_libc.c? That's at least strncoll_libc(),
>> strnxfrm_libc(). I think all the in-core callers guard them, but the
>> protection seems mighty far away in some cases.
>
> We don't have a lot of time to think about this, and AFAICS the
> security patch only added calls to pg_strupper and pg_strlower.
> So as long as those are protected I'm content to ship.
+1. It'd be good to look at those, but not right now.
I have pushed the fix.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexandre Felipe | 2026-08-11 18:27:37 | Re: Restructured Shared Buffer Hash Table |
| Previous Message | Alexandre Felipe | 2026-08-11 18:15:48 | [PATCH] bufmgr: tighten LWLock:BufferMapping on InvalidateBuffer |