Re: [I|S]CONST/[I|S]const in gram.y

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Meskes <meskes(at)postgresql(dot)org>
Cc: PostgreSQL Hacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [I|S]CONST/[I|S]const in gram.y
Date: 2008-11-10 13:12:49
Message-ID: 3208.1226322769@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Meskes <meskes(at)postgresql(dot)org> writes:
> is there a reason why we sometimes use ICONST and SCONST directly in a rule in
> gram.y yet in other rules use Iconst and Sconst which in turn resolve to ICONST
> and SCONST? Some rules even use ICONST and Sconst, so there does not be any
> consistency.

Seems like an obvious no-op.

> If this has no reason I'd like to make all rules use the same
> symbol which will make gram.y be consequent in its symbol usage and simplify my
> work to generate the ecpg parser out of an unchanged gram.y at the same time.

Which direction are you hoping to go --- remove Iconst/Sconst, or use
them everywhere?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zdenek Kotala 2008-11-10 13:26:36 Re: WIP: Page space reservation (pgupgrade)
Previous Message Alvaro Herrera 2008-11-10 12:47:38 Re: Short CVS question