Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

--On Friday, March 19, 2004 10:15:56 -0500 Bruce Momjian
<pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:

>> [moved to -patches because of the patch]
>>
>>
>> --On Friday, March 19, 2004 08:01:53 -0500 Bruce Momjian
>> <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
>>
>> > Larry Rosenman wrote:
>> >> > I thought that once you include libpthread in libpq, that you don't
>> >> > have to mention it again then you use libpq. Is your platform
>> >> > different somehow in this regard?
>> >> >
>> >> > I seem to remember this problem with libcrypt and libpq. Is this
>> >> > the same problem?
>> >> >
>> >> > I see that initdb is just the first of many /bin programs to be
>> >> > compiled, so if we have to add the thread lib, we will have to do it
>> >> > for all the bin programs. Yikes. Why wasn't this a problem for
>> >> > 7.4?
>> >> 7.4 had initdb as a Shell Script.
>> >> the 7.4.x libpq didn't have any pthread_* references in it, that I see
>> >> on my box.
>> >
>> > Ah, yes. We added the thread-local storage to handle SIGPIPE. The
>> > problem is that initdb isn't the only place. If you comment out initdb
>> > from the Makefile in src/bin, does the next make fail too? I bet it
>> > does.
>>
>> Apparently, because of the way the wrappers work, having -lpthread on
>> libpq.so does NOT add it to the NEEDED list.
>>
>> I made the following patch, and all compiles now:
>
> Yes, I was afraid of that. Is there any way to make it work? If not,
> evey libpq program you create will need -lpthread added.
I think we need to mention if you --enable-thread-safety you MUST use
-lpthread on UnixWare, at least. I don't know about other platforms.

I'll ask the compiler guys, but I suspect we're going to have to do it this
way.

LER

>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
> + If your life is a hard drive, | 13 Roberts Road
> + Christ can be your backup. | Newtown Square, Pennsylvania
> 19073

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749