Re: [COMMITTERS] pgsql: Introduce dynamic shared memory areas.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Introduce dynamic shared memory areas.
Date: 2016-12-05 15:09:05
Message-ID: 32050.1480950545@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> This commit is generating a warning when compiling on my Win7 dev box:

dromedary has this:

ccache gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -g -O2 -ansi -I../../../../src/include -DCOPY_PARSE_PLAN_TREES -DRAW_EXPRESSION_COVERAGE_TEST -c -o network_selfuncs.o network_selfuncs.c
dsa.c: In function 'dsa_dump':
dsa.c:1106: warning: format '%016lx' expects type 'long unsigned int', but argument 3 has type 'dsa_pointer'
dsa.c:1106: warning: format '%016lx' expects type 'long unsigned int', but argument 4 has type 'dsa_pointer'
dsa.c: In function 'make_new_segment':
dsa.c:2039: warning: left shift count >= width of type
dsa.c:2039: warning: left shift count >= width of type
dsa.c:2077: warning: left shift count >= width of type

The first two of those should be fixed by 670b3bc8f, but the shift
problems remain.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-12-05 15:09:28 Re: [COMMITTERS] pgsql: Introduce dynamic shared memory areas.
Previous Message Robert Haas 2016-12-05 15:02:44 pgsql: Try to fix some DSA-related compiler warnings.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-12-05 15:09:28 Re: [COMMITTERS] pgsql: Introduce dynamic shared memory areas.
Previous Message Robert Haas 2016-12-05 15:04:44 Re: Dynamic shared memory areas