Re: pgsql: Minor pg_dump improvements

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> grep shows me a couple of other places where the result of ftello doesn't
>> seem to be getting checked for error. Odd that Coverity didn't notice
>> those.

> At least two of those are in a #if 0 block... since 2001
> (pg_backup_tar.c:_tarGetHeader). I'm thinking we may be better off
> removing that code rather than continuing to pull it along

Works for me.

> The last is inside a snprintf() which is just building a string to call
> exit_horribly() with- seems like that's safe enough?

Agreed. Printing -1 seems like appropriate behavior there.

regards, tom lane