Re: ReplicationSlotCtl: undefined reference

From: Pavlo Golub <pavlo(dot)golub(at)cybertec(dot)at>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com>
Subject: Re: ReplicationSlotCtl: undefined reference
Date: 2019-06-13 15:15:42
Message-ID: 31fd6afb-8f09-415a-8c78-eb3d4931741d@email.android.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

<div dir='auto'><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Jun 13, 2019 17:56, Tom Lane &lt;tgl(at)sss(dot)pgh(dot)pa(dot)us&gt; wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Pavlo Golub &lt;pavlo(dot)golub(at)cybertec(dot)at&gt; writes:
<br>
&gt; Trying to build pg extension I've got error:
<br>
&gt; ```
<br>
&gt; pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl'
<br>
&gt; collect2: error: ld returned 1 exit status
<br>
&gt; ```
<br>

<br>
&gt; But according to https://commitfest.postgresql.org/16/1390/ it should
<br>
&gt; be marked with PGDLLIMPORT.
<br>

<br>
That last bit never actually got pushed, it seems.&nbsp; Done now.
<br></p></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Thanks Tom. Really appreciate that!</div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">

<br>
regards, tom lane
<br>
</p>
</blockquote></div><br></div></div></div>

Attachment Content-Type Size
unknown_filename text/html 1.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jesper Pedersen 2019-06-13 16:31:54 Re: Index Skip Scan
Previous Message Pavel Trukhanov 2019-06-13 15:13:54 Re: Improve handling of pg_stat_statements handling of bind "IN" variables