Re: DEREF_AFTER_NULL: src/common/jsonapi.c:2529

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Галкин Сергей <galkin(at)rutoken(dot)ru>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DEREF_AFTER_NULL: src/common/jsonapi.c:2529
Date: 2026-04-06 12:01:41
Message-ID: 31e5b65e-84f1-40c3-a7b8-6c26ae450208@proxel.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/6/26 1:59 PM, Andreas Karlsson wrote:
> If someone has a patch improving readability I would personally before
> merging this since this code feels more complex than it ideally should
> be but adding this noop NULL check to silence a false positive from a
> static analyzer does not seem like an improvement.

Whops, accidentally forgot to type some words there. That should have been:

"[...] I would personally be all for merging it since this code [...]"

--
Andreas Karlsson
Percona

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2026-04-06 12:02:35 Re: Batching in executor
Previous Message Andreas Karlsson 2026-04-06 11:59:01 Re: DEREF_AFTER_NULL: src/common/jsonapi.c:2529