| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(at)vondra(dot)me>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_waldump: support decoding of WAL inside tarfile |
| Date: | 2026-04-10 12:57:14 |
| Message-ID: | 31c4ce3c-b645-4e43-a5ac-7b290cfefbc3@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-04-10 Fr 3:57 AM, Thomas Munro wrote:
> Nitpicking code review for commit b15c1513:
>
> +read_archive_wal_page(XLogDumpPrivate *privateInfo, XLogRecPtr targetPagePtr,
> + Size count, char *readBuff)
>
> I thought we agreed to stop using Size for new code? size_t has been
> around since C89.
Must have missed the memo :-(
>
> + pg_fatal("WAL segment \"%s\" in archive \"%s\" is too short: rea
> d %lld of %lld bytes",
> + fname, privateInfo->archive_name,
> + (long long int) (count - nbytes),
> + (long long int) count);
>
> Why cast to long long int? That's the sort of thing we used to have
> to do for int64 (but no longer), but here it's size_t anyway. %zu has
> been around since C99.
will fix. Thanks for looking.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dapeng Wang | 2026-04-10 13:01:32 | Re: Fix pgstat_database.c to honor passed database OIDs |
| Previous Message | Tender Wang | 2026-04-10 12:49:24 | Re: pg17: XX000: no relation entry for relid 0 |