Re: [PATCH] Fix null pointer dereference in PG19

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix null pointer dereference in PG19
Date: 2026-07-10 08:42:29
Message-ID: 31b38752-d16f-465f-9e85-b01e6da9d36c@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09.07.26 17:22, Paul A Jungwirth wrote:
> Checking at v1 is Aleksander's original patch. Then v2 adds tests that
> crash the server. v3 moves the check to rewrite time, and the tests
> pass. v4 moves the check again to exec time. But v4 is a behavior
> change: an UPDATE that touches zero rows no longer fails. I thought
> that was weird; that's why I recommended leaving it out (in
> https://www.postgresql.org/message-id/
> CA%2BrenyXPEJYOVov3XtzTp3NusGkObc9UeW-Nm78K8_nsWSnnfg%40mail.gmail.com
> before I added the crashing tests).

I committed patches 0001 through 0003 (squashed).

I think I was mistaken about the need for an executor check (patch
0004). But we can add it on if a need appears.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2026-07-10 08:52:36 Re: Proposal: INSERT ... BY NAME
Previous Message shveta malik 2026-07-10 08:40:38 Re: sequencesync worker race with REFRESH SEQUENCES