From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Extensions not dumped when --schema is used |
Date: | 2021-02-20 16:31:40 |
Message-ID: | 3197673.1613838700@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> As presented in this patch, specifying both --extension and
> --table/--schema means that pg_dump will dump both tables and
> extensions matching the pattern passed down. But shouldn't extensions
> not be dumped if --table or --schema is used? Combining --schema with
> --table implies that the schema part is ignored, for instance.
I haven't read the patch, but the behavior I would expect is:
1. If --extension=pattern is given, then extensions matching the
pattern are included in the dump, regardless of other switches.
(Conversely, use of --extension doesn't affect choices about what
other objects are dumped.)
2. Without --extension, the behavior is backward compatible,
ie, dump extensions in an include_everything dump but not
otherwise.
Maybe we could have a separate discussion as to which switches turn
off include_everything, but that seems independent of this patch.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2021-02-20 16:55:46 | Re: repeated decoding of prepared transactions |
Previous Message | Tom Lane | 2021-02-20 16:20:50 | Re: computing dT from an interval |