Re: Possible typo in an error message

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andreas Karlsson <andreas(at)proxel(dot)se>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Possible typo in an error message
Date: 2026-07-10 08:05:33
Message-ID: 318D357F-9EB7-4CAC-A4C0-CF996958461A@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 10 Jul 2026, at 09:31, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
>
> On 7/10/26 06:52, Kyotaro Horiguchi wrote:
>> While translating this message, I noticed the following error text:
>> parse_jsontable.c:644:
>>> errdetail("PATH name was %s not found in nested columns list.",
>> Is this perhaps meant to be
>> PATH name %s was not found in nested columns list.
>> instead?
>
> Agreed, or maybe:
>
> "Path name %s not found in nested columns list."
>
> From what I can see both forms are used in our error messages.

I would favor "was not found" since the JSON_TABLE support has a similar
wording for missing PLAN clauses: "PLAN clause for nested path %s was not
found". Consistency within a feature is good.

>> Also, I wasn't quite sure whether the uppercase "PATH" in messages
>> such as "PATH name" has any particular significance. For the
>> translation, I ended up treating it as the ordinary word "path", since
>> I couldn't tell whether it was intended to refer to the SQL keyword or
>> just the general concept.
>
> Agreed, it does not look like it is a keyword so it should not be written in upper case.

I think it does refer to the PATH keyword in a NESTED PATH clause. See below
for an example query from our regression tests:

SELECT * FROM JSON_TABLE(
jsonb '[]', '$' AS path1
COLUMNS (
NESTED PATH '$' COLUMNS (
foo int PATH '$'
)
)
PLAN DEFAULT (UNION)
) jt;

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2026-07-10 08:06:42 Re: Proposal: INSERT ... BY NAME
Previous Message Jim Jones 2026-07-10 07:46:59 Re: Proposal: INSERT ... BY NAME