Re: The unused_oids script should have a reminder to use the 8000-8999 OID range

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: The unused_oids script should have a reminder to use the 8000-8999 OID range
Date: 2019-08-06 05:41:18
Message-ID: 31898.1565070078@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> On Mon, Aug 5, 2019 at 8:47 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> Wouldn't it be better to keep some room at the end of the allowed
>> array? Or at least avoid suggesting ranges where there is less than
>> 3-5 OIDs available consecutively.

> Not in my view. There is value in having simple, predictable behavior.

There was some discussion of that upthread, and Peter argued that many
patches only need one OID anyway so why try harder. I'm not totally
sure I buy that --- my sense is that even simple patches tend to add
several related functions not just one. But as long as the script
tells you how many OIDs are available, what's the problem? Just run
it again if you want a different suggestion, or make your own choice.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ian Barwick 2019-08-06 05:53:10 Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
Previous Message Tom Lane 2019-08-06 05:32:52 Re: pg can create duplicated index without any errors even warnning