Re: truncating pg_multixact/members

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: truncating pg_multixact/members
Date: 2014-02-12 18:34:03
Message-ID: 31820.1392230043@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> In this new version, I added a couple of fields to VacuumStmt node. How
> strongly do we feel this would cause an ABI break? Would we be more
> comfortable if I put them at the end of the struct for 9.3 instead?

In the past we've usually added such members at the end of the struct
in back branches (but put them in the logical place in HEAD). I'd
recommend doing that just on principle.

> Also, AutoVacOpts (used as part of reloptions) gained three extra
> fields. Since this is in the middle of StdRdOptions, it'd be somewhat
> more involve to put these at the end of that struct. This might be a
> problem if somebody has a module calling RelationIsSecurityView(). If
> anyone thinks we should be concerned about such an ABI change, please
> shout quickly.

That sounds problematic --- surely StdRdOptions might be something
extensions are making use of?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2014-02-12 18:42:07 Re: Recovery inconsistencies, standby much larger than primary
Previous Message Andres Freund 2014-02-12 18:19:29 Re: narwhal and PGDLLIMPORT