| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: move some bitmapset.c macros to bitmapset.h |
| Date: | 2022-12-05 14:32:59 |
| Message-ID: | 3174322.1670250779@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2022-Dec-05, John Naylor wrote:
>> -#define WORDNUM(x) ((x) / BITS_PER_BITMAPWORD)
>> -#define BITNUM(x) ((x) % BITS_PER_BITMAPWORD)
> In this location, nobody can complain about the naming of these macros,
> since they're just used to implement other bitmapset.c code. However,
> if you move them to the .h file, ISTM you should give them more
> meaningful names.
IMV these are absolutely private to bitmapset.c. I reject the idea
that they should be exposed publicly, under these names or any others.
Maybe we need some more bitmapset primitive functions? What is it
you actually want to accomplish in the end?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2022-12-05 14:42:35 | Re: Allow placeholders in ALTER ROLE w/o superuser |
| Previous Message | Alexander Korotkov | 2022-12-05 13:51:01 | Re: Allow placeholders in ALTER ROLE w/o superuser |