Re: Re: popen and pclose redefinitions causing many warning in Windows build

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: popen and pclose redefinitions causing many warning in Windows build
Date: 2014-05-28 16:29:28
Message-ID: 31703.1401294568@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> I think this is caused because the variable is not defined as SOCKET.
> The attached patch fixes this. This should prevent the warning.

Surely that's just going to move the errors somewhere else. The call
site still expects the argument to be int[].

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Keith Fiske 2014-05-28 17:28:41 Re: BUG #9652: inet types don't support min/max
Previous Message Alvaro Herrera 2014-05-28 16:19:03 Re: Re-create dependent views on ALTER TABLE ALTER COLUMN ... TYPE?