Re: tab completion for CREATE USER MAPPING

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tab completion for CREATE USER MAPPING
Date: 2016-02-23 14:53:43
Message-ID: 31675.1456239223@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> Attached patch implements the tab-completion for CREATE USER MAPPING command.
> Comments?

I think it's really bad style to use "Query_for_list_of_users"
as the name of a query that does not in fact deliver a list of
user names, but something else with only one specialized use.
Something like "Query_for_list_of_users_plus_MAPPING" would be
less likely to trip up the unwary in future patches.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-02-23 15:37:07 Re: Sanity checking for ./configure options?
Previous Message Tom Lane 2016-02-23 14:46:53 Re: [HACKERS] JDBC behaviour