| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Oversight in reparameterize_path_by_child leading to executor crash |
| Date: | 2023-08-22 15:43:29 |
| Message-ID: | 3163033.1692719009@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> ... I think the risk/reward ratio for messing with this in the
> back branches is unattractive in any case: to fix a corner case that
> apparently nobody uses in the field, we risk breaking any number of
> mainstream parameterized-path cases. I'm content to commit the v5 patch
> (or a successor) into HEAD, but at this point I'm not sure I even want
> to risk it in v16, let alone perform delicate surgery to get it to work
> in older branches. I think we ought to go with the "tablesample scans
> can't be reparameterized" approach in v16 and before.
Concretely, about like this for v16, and similarly in older branches.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Dont-reparameterize-sample-scans.patch | text/x-diff | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2023-08-22 16:07:22 | Re: Oversight in reparameterize_path_by_child leading to executor crash |
| Previous Message | Peter Eisentraut | 2023-08-22 14:57:02 | Re: [PATCH] Add function to_oct |