|From:||David Steele <david(at)pgmasters(dot)net>|
|To:||Stephen Frost <sfrost(at)snowman(dot)net>|
|Cc:||Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: PATCH: Configurable file mode mask|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 4/6/18 10:22 PM, Stephen Frost wrote:
> * David Steele (david(at)pgmasters(dot)net) wrote:
>> On 4/6/18 6:04 PM, David Steele wrote:
>>> On 4/6/18 3:02 PM, Stephen Frost wrote:
>>>> - Further discussion in the commit messages
>>> Agreed, these need some more work. I'm happy to do that but I'll need a
>>> bit more time. Have a look at the new patches and I'll work on some
>>> better messages.
>> I'm sure you'll want to reword some things, but I think these commit
>> messages capture the essential changes for each patch.
> Thanks much. I've taken (most) of these, adjusting a few bits here and
> I've been back over the patch again, mostly improving the commit
> messages, comments, and docs. I also looked over the code and tests
> again and they're looking pretty good to me, so I'll be looking to
> commit this tomorrow afternoon or so US/Eastern.
OK, one last review. I did't make any code changes, but I improved some
comments, added documentation and fixed a test.
01) Refactor dir/file permissions
* Small comment update, replace "such cases-" with "such cases --".
02) Allow group access on PGDATA
* Add data_directory_mode guc to "Preset Options" documentation.
* Add a section to the documentation that discusses changing the
permissions of an existing cluster.
* Improved comment on checkControlFile().
* Comment wordsmithing for SetDataDirectoryCreatePerm() and
* Fixed ordering of -g option in initdb documentation.
* Fixed a new test that was "broken" by 032429701e477. It was broken
before but the rmtrees added in 032429701e477 exposed the problem.
Attached are the v19 patches.
|Next Message||Simon Riggs||2018-04-07 17:19:19||Re: pgsql: New files for MERGE|
|Previous Message||Tom Lane||2018-04-07 17:06:48||Re: Removing useless DISTINCT clauses|