Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mark Dilger <hornschnorter(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders
Date: 2017-04-23 05:26:46
Message-ID: 31534.1492925206@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
>> On Apr 22, 2017, at 11:40 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> In short then, I propose the attached patch to make these cases fail
>> more reliably. We might extend this later to allow the old behaviors
>> to be explicitly opted-into, but we don't seem to need that today.

> I pulled fresh sources with your latest commit, 7d68f2281a4b56834c8e5648fc7da0b73b674c45,
> and the tests consistently fail (5 out of 5 attempts) for me on my laptop with:

> Are the errors expected now?

Yes, as of right now, if HEAD *doesn't* fail the src/test/recovery tests
for you in an assert-enabled build, that would be surprising. The next
step is to actually fix the bugs ... but the point of commit 7d68f2281
was to make these failures reproducible, which they were not before.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-04-23 06:01:34 Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders
Previous Message Mark Dilger 2017-04-23 02:44:28 Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-04-23 06:01:34 Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders
Previous Message Mark Dilger 2017-04-23 02:44:28 Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders