Re: [HACKERS] psql 'none' as a HISTFILE special case

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Martin Atukunda" <matlads(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, "Bruce Momjian" <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] psql 'none' as a HISTFILE special case
Date: 2006-08-25 17:46:11
Message-ID: 3147.1156527971@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Martin Atukunda" <matlads(at)gmail(dot)com> writes:
> On 8/25/06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> There's probably no way to get Apple's libedit to not try the fchmod,
>> so what do we want to do here? Maybe special-case the string
>> "/dev/null"?

> If this is OK, I can up with a patch that special cases /dev/null as a
> HISTFILE if libedit is found.

I was thinking of basically a one-liner addition to write_history
to skip the whole thing if strcmp(fname, DEVNULL) == 0. Should be
reasonably inoffensive on anyone's machine.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-08-25 17:48:06 Re: Tricky bugs in concurrent index build
Previous Message Alvaro Herrera 2006-08-25 17:37:40 Re: Tricky bugs in concurrent index build

Browse pgsql-patches by date

  From Date Subject
Next Message Martin Atukunda 2006-08-25 18:02:43 Re: [HACKERS] psql 'none' as a HISTFILE special case
Previous Message Zoltan Boszormenyi 2006-08-25 17:37:34 Re: Performance testing of COPY (SELECT) TO