Re: Annoying build warnings from latest Apple toolchain

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Annoying build warnings from latest Apple toolchain
Date: 2023-10-07 16:09:06
Message-ID: 3143865.1696694946@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2023-10-05 13:37:38 -0400, Tom Lane wrote:
>> Hm. IIUC that would result in an error if someone did try to
>> put some c_args into default_bin_args, and I didn't think it would
>> be appropriate for this code to fail in such a case. Still, I see
>> there are a bunch of other ways to inject globally-used compilation
>> flags, so maybe you're right that it'd never need to happen.

> I think the other ways of injecting c_args compose better (and indeed other
> options are either injected globally, or via declare_dependency()).

Done that way.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2023-10-07 17:38:54 Re: Fix a typo in _bt_readpage
Previous Message Alvaro Herrera 2023-10-07 13:54:33 Re: remaining sql/json patches