Re: [PATCH] Store Extension Options

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Fabrizio Mello <fabriziomello(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Store Extension Options
Date: 2014-01-05 20:45:20
Message-ID: 31428.1388954720@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sat, Jan 4, 2014 at 1:00 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I would suggest addressing Robert's concern about lack of error checking
>> by refusing to allow a custom reloption to be set unless the relevant
>> extension is loaded and checks it. Unlike the postgresql.conf problem,
>> I don't see any very good use-case for allowing an unchecked ALTER TABLE
>> to occur.

> How do you plan to resolve the associated dump/restore hazard?

pg_dump creates extensions before tables, no? So what dump/restore
hazard?

> AIUI,
> that's why we allow people define any old this.that GUC that they want
> without checking it - because the relevant shared library might not be
> loaded at the time of definition, but only by time of use.

No, the reason we allow GUCs to be set before the relevant library is
loaded is so that you can put a setting into postgresql.conf without
thereby having to make the extension be load-into-postmaster.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-01-05 20:58:00 Re: [PATCH] SQL assertions prototype
Previous Message Tom Lane 2014-01-05 20:41:49 Re: more psprintf() use