Re: Segmentation fault using digest from pg_crypto

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Manuel Sugawara <masm(at)fciencias(dot)unam(dot)mx>
Cc: "Marko Kreen" <markokr(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Segmentation fault using digest from pg_crypto
Date: 2007-08-24 17:53:59
Message-ID: 3134.1187978039@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Manuel Sugawara <masm(at)fciencias(dot)unam(dot)mx> writes:
> "Marko Kreen" <markokr(at)gmail(dot)com> writes:
>> In 8.0 the pgcrypto functions were non-strict and checked for NULLs.
>> In 8.1 they were made STRICT.
>> In 8.2 the NULL check were removed from code.

> Not an smart move IMHO, I didn't create the function, it was created
> as part of my upgrade process. May I suggest to put back the check?.

That's the standard way of doing things in C functions (ie, rely on
STRICT markings) and I see nothing wrong with it. If you were using an
upgrade process that failed to incorporate version-to-version changes in
the definitions of contrib functions, this is hardly going to be the
only problem you encounter.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Manuel Sugawara 2007-08-24 18:31:10 Re: Segmentation fault using digest from pg_crypto
Previous Message Tom Lane 2007-08-24 17:37:53 Re: Final background writer cleanup for 8.3