Re: Frontend error logging style

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Frontend error logging style
Date: 2022-10-11 15:08:47
Message-ID: 312889.1665500927@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> writes:
> Hi!
> Commit 9a374b77fb53 (Improve frontend error logging style.) replaced a
> line of file src/include/common/logging.h
> ```
> extern PGDLLIMPORT enum pg_log_level __pg_log_level;
> ```
> to
> ```
> extern enum pg_log_level __pg_log_level;
> ```
> i.e. it is rollback of commit 8ec569479fc28 (Apply PGDLLIMPORT markings
> broadly.)

> Is it correct?

Yes, since that file is frontend-only.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2022-10-11 15:11:39 Re: Warning about using pg_stat_reset() and pg_stat_reset_shared()
Previous Message Peter Eisentraut 2022-10-11 15:06:22 Make finding openssl program a configure or meson option