Re: [HACKERS] Index only scan for cube and seg

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Index only scan for cube and seg
Date: 2017-11-21 01:30:00
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andrey Borodin <x4mmm(at)yandex-team(dot)ru> writes:
>> 29 окт. 2017 г., в 2:24, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> написал(а):
>> Thus, it should be safe to just remove both compress/decompress methods from existing opclass.

> Alexander, Tom, you are absolutely right. I was sure there is toasting code in cube's compress, but it was not ever there.
> Here is patch for cube that drops functions.

I've pushed this with a few adjustments:

* I wasn't satisfied with the amount of schema-qualification in the
pg_depend update queries. I thought they could do with comments
explaining what they were doing and why, as well.

* I didn't have much confidence in the new cube test case producing
a consistent row order across all platforms, so I added an ORDER BY.
I made some other cosmetic adjustments to the tests too.

* In both modules, you'd forgotten to update the alternative

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-11-21 03:36:42 Combine function returning NULL unhandled?
Previous Message Craig Ringer 2017-11-21 01:29:50 Re: Using isatty() on WIN32 platform