Re: Index only scan for cube and seg

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Index only scan for cube and seg
Date: 2017-10-29 08:38:43
Message-ID: 764057ED-BE57-49E0-B10A-19C80F956108@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!
> 29 окт. 2017 г., в 2:24, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> написал(а):
>
> As I can see, cube GiST code always uses DatumGetNDBOX() macro to transform Datum to (NDBOX *).
>
> #define DatumGetNDBOX(x) ((NDBOX *) PG_DETOAST_DATUM(x))
>
> Thus, it should be safe to just remove both compress/decompress methods from existing opclass.

Alexander, Tom, you are absolutely right. I was sure there is toasting code in cube's compress, but it was not ever there.

Here is patch for cube that drops functions.

Best regards, Andrey Borodin.

Attachment Content-Type Size
0001-Enable-Index-Only-Scan-in-cube.patch application/octet-stream 4.8 KB
0001-Enable-Index-Only-Scan-in-seg.patch application/octet-stream 4.3 KB
unknown_filename text/plain 2 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Travers 2017-10-29 08:51:55 Re: proposal: schema variables
Previous Message Robert Haas 2017-10-29 07:45:52 Re: Parallel worker error