Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.
Date: 2014-07-29 14:10:02
Message-ID: 31263.1406643002@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
> Treat 2PC commit/abort the same as regular xacts in recovery.

Looking at this again ... didn't you just break recoveryStopsBefore?
ISTM the added line

if (record_info == XLOG_XACT_COMMIT_PREPARED)

needs to be

else if (record_info == XLOG_XACT_COMMIT_PREPARED)

As it stands, control will reach the "return false" for regular
commit records.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-07-29 14:27:11 pgsql: Oops, fix recoveryStopsBefore functions for regular commits.
Previous Message Heikki Linnakangas 2014-07-29 09:02:55 pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.