| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags |
| Date: | 2010-12-11 16:13:12 |
| Message-ID: | 3126.1292083992@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
I wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> This broke the buildfarm on Windows, and I'm not sure of the best way to fix it.
> Hm, those symbols are already in use elsewhere in the code; I would
> assume it's just a matter of missing #includes in these particular
> files. Where does Windows define 'em?
Ah, I have a theory: <fcntl.h>. Seems that ancient Unix specs say
S_IRUSR etc should be defined there, rather than <sys/stat.h> which
is the modern expectation. Count on M$ to find creative ways of being
incompatible ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2010-12-11 16:18:51 | Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags |
| Previous Message | Tom Lane | 2010-12-11 15:27:07 | Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2010-12-11 16:18:51 | Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags |
| Previous Message | Tom Lane | 2010-12-11 15:56:19 | Re: create tablespace fails silently, or succeeds improperly |