Bizarre coding in recovery target GUC management

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Bizarre coding in recovery target GUC management
Date: 2020-10-12 16:00:45
Message-ID: 3124549.1602518445@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Would someone explain to me why assign_recovery_target_lsn and related GUC
assign hooks throw errors, rather than doing so in the associated check
hooks? An assign hook is not supposed to throw an error. Full stop, no
exceptions. We wouldn't bother to separate those hooks otherwise.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2020-10-12 16:57:38 Re: partition routing layering in nodeModifyTable.c
Previous Message Tom Lane 2020-10-12 15:13:38 Re: BUG #15858: could not stat file - over 4GB