Re: pgsql: Fix page modification outside of critical section in GIN

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix page modification outside of critical section in GIN
Date: 2020-02-09 17:05:32
Message-ID: 31240.1581267932@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:
> Alexander Korotkov <akorotkov(at)postgresql(dot)org> writes:
>> Fix page modification outside of critical section in GIN

> I happened to notice, while reviewing stuff for the release notes,
> that this patch does not do what the commit message says. The
> previous code modified the pd_prune_xid of the "dBuffer" page,
> but now it's modifying the pd_prune_xid of the "lBuffer" page.
> Is that actually correct?

Since we're rapidly approaching the wrap deadline for this week's
releases, I took it upon myself to review this code more carefully,
and concluded that indeed it isn't correct. I pushed a fix that
moves the GinPageSetDeleteXid call again.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-02-09 19:14:54 pgsql: Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26.
Previous Message Tom Lane 2020-02-09 17:03:12 pgsql: Store the deletion horizon XID for a deleted GIN page on the rig