| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Mark Dilger <hornschnorter(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: "SELECT ... FROM DUAL" is not quite as silly as it appears |
| Date: | 2019-01-15 00:17:24 |
| Message-ID: | 31228.1547511444@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> 1. I don't think having a table named "dual" makes a whole lot of
> sense for a table with a single row.
Well, I borrowed Oracle terminology there ;-)
> (Uppercasing these additions would also make them look less of an afterthought.)
Don't really care, can do.
> I also did a quick benchmark of v6 and found the slowdown to be
> smaller after the change made in build_simple_rel()
Thanks for confirming. I was not very sure that was worth the extra
few bytes of code space, but if you see a difference too, then it's
probably worthwhile.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-01-15 00:48:16 | Re: [Sender Address Forgery]Re: error message when subscription target is a partitioned table |
| Previous Message | David Rowley | 2019-01-15 00:11:08 | Re: "SELECT ... FROM DUAL" is not quite as silly as it appears |