Re: [GENERAL] pg_upgrade ?deficiency

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Kevin Grittner <kgrittn(at)ymail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Karsten Hilbert <Karsten(dot)Hilbert(at)gmx(dot)net>, "Hilbert, Sebastian" <Sebastian(dot)Hilbert(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GENERAL] pg_upgrade ?deficiency
Date: 2013-11-30 22:03:31
Message-ID: 31224.1385849011@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> I have fixed pg_upgrade in git-head with the attached patch, which
> prepends default_transaction_read_only=false to PGOPTIONS.

What is the point of this, given that Kevin fixed pg_dumpall? Don't
those fixes take care of the issue?

If your argument is that you want pg_upgrade to work even if the
user already turned on default_transaction_read_only in the *new*
cluster, I would humbly disagree with that goal, for pretty much
the same reasons I didn't want pg_dump overriding it.

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Thomas Kellerer 2013-11-30 22:21:36 Re: Full Stored Procedure Support, any time soon ?
Previous Message Noel Diaz 2013-11-30 21:56:52 Re: Full Stored Procedure Support, any time soon ?

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2013-11-30 22:03:43 Re: Extension Templates S03E11
Previous Message Dimitri Fontaine 2013-11-30 21:55:39 Re: Extension Templates S03E11