Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.
Date: 2017-09-06 18:37:30
Message-ID: 31190.1504723050@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
> Thus short, simple but meaningful examples which show how to do something
> useful with all that in the documentation may help people take advantage
> of these new features.

I don't have an objection to providing an example. I wasn't terribly
impressed with Simon's version, but maybe we can do better. I think
it should be concrete, not partly abstract; and likely it needs to be
with \if not the variable proper.

> Given my experience with "\d*", I'm not sure I would assume that a new
> psql feature would work with older servers.

I don't recall anyone questioning whether PQserverVersion() would work
with older servers. Being able to tell what version the server is is
sort of the point, no? If there were a restriction on what it would
work with, I would agree that that needs to be documented. But I
don't think "yes, it really works" is a helpful use of documentation
space.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fabien COELHO 2017-09-06 18:58:57 Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.
Previous Message Tom Lane 2017-09-06 18:21:53 pgsql: Remove duplicate reads from the inner loops in generic atomic op

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2017-09-06 18:45:25 Re: PoC plpgsql - possibility to force custom or generic plan
Previous Message Tom Lane 2017-09-06 18:31:26 Re: Fix performance of generic atomics