Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Matteo Beccati <php(at)beccati(dot)com>
Cc: pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Date: 2014-05-26 17:25:49
Message-ID: 31183.1401125149@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Matteo Beccati <php(at)beccati(dot)com> writes:
> I'm attaching v2 of the patch. Here's a list of changes from v1:

> * Restored --with-ossp-uuid. Configure tries ossp support first, then
> falls back to Linux and BSD variants
> * md5.o and sha1.o are linked only when not using the ossp library
> * fixed a bug in the v1mc generation carried over from uuid-freebsd:
> only the mac part is randomized now
> * updated regression tests, which are now passing on ubuntu w/ and w/o
> ossp and netbsd.

> This was the best I could achieve in the limited timeframe I had
> available. I believe it could be a good starting point for your final
> refactoring.

I've not reviewed this in any detail yet, but I believe we're in agreement
on the general ideas. I do think that we need two separate configure
switches: one asking to use the OSSP library and one asking to use the
other library. That's an easy change though.

Assuming this works as advertised, does anyone have an objection to
pushing it into 9.4?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-05-26 17:31:31 Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Previous Message Heikki Linnakangas 2014-05-26 17:22:38 Re: Spreading full-page writes