Re: [HACKERS] pg_serial early wraparound

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] pg_serial early wraparound
Date: 2018-03-26 16:50:00
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> Rebased again, now with a commit message. That assertion has since
> been removed (commit ec99dd5a) so the attached test script can once
> again be used to see the contents of pg_serial as the xid goes all the
> way around, if you build with TEST_OLDSERXID defined so that
> predicate.c forces information about xids out to pg_serial.

Couple thoughts here ---

Seems like if the patch is correct as-is, then the OldSerXidPage
macro could be simplified, as the modulo no longer does anything.
Also, OldSerXidSegment doesn't seem to be used.

I'm a little worried because Anastasia couldn't repeat the test;
why is that?

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-03-26 16:52:37 Re: [HACKERS] MERGE SQL Statement for PG11
Previous Message Dmitry Ivanov 2018-03-26 16:48:19 Re: new function for tsquery creartion