Re: TM format can mix encodings in to_char()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: TM format can mix encodings in to_char()
Date: 2019-04-21 04:28:48
Message-ID: 31056.1555820928@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

I wrote:
> [ fix-encoding-and-error-recovery-in-cache-locale-time.patch ]

On closer inspection, I'm pretty sure either version of this patch
will break things on Windows, because that platform already had code
to convert the result of wcsftime() to the database encoding; we
were adding code to do a second conversion, which will not go well.

The attached revised patch deletes the no-longer-necessary
platform-specific recoding stanza, in favor of having cache_locale_time
know that it's getting UTF8 rather than something else. I also
updated a bunch of the related comments.

I don't have any way to test this on Windows, so could somebody
do that? Manually running the Turkish test cases ought to be enough.

regards, tom lane

Attachment Content-Type Size
fix-encoding-and-error-recovery-in-cache-locale-time-2.patch text/x-diff 18.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2019-04-21 06:25:43 Re: Runtime pruning problem
Previous Message Bruce Momjian 2019-04-20 21:54:45 Re: finding changed blocks using WAL scanning