| From: | "Gunnar \"Nick\" Bluth" <gunnar(dot)bluth(at)pro-open(dot)de> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Alexander Kukushkin <cyberdemn(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, x4mmm(at)yandex-team(dot)ru, kondratovaleksey(at)gmail(dot)com |
| Subject: | Re: PATCH: add "--config-file=" option to pg_rewind |
| Date: | 2022-02-25 09:35:49 |
| Message-ID: | 30d664bc-09c8-981d-42ff-0cacb109c787@pro-open.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Am 24.02.22 um 14:46 schrieb Daniel Gustafsson:
>> On 24 Feb 2022, at 14:43, Gunnar Nick Bluth <gunnar(dot)bluth(at)pro-open(dot)de> wrote:
>
>> That looks just as good to me, and it already has tests, so I'll happily step down!
>
> Actually, I think this looks like a saner approach. Putting a config setting
> in two place (postgresql.conf and on the commandline for pg_rewind) is a recipe
> for them diverging.
Well, well,
reverted https://commitfest.postgresql.org/37/3562/ back to "needs
review" and moved it to "Replication & Recovery".
Patch v2 includes:
* doc improvements as suggested
* tests shamelessly copied & adapted from
https://commitfest.postgresql.org/37/3213/
Since the need is pretty obvious (I *think* the Debian-ish userbase is
quite significant alone), I'd love to see one of the approaches making
it into 15!
Best regards,
--
Gunnar "Nick" Bluth
Eimermacherweg 106
D-48159 Münster
Mobil +49 172 8853339
Email: gunnar(dot)bluth(at)pro-open(dot)de
__________________________________________________________________________
"Ceterum censeo SystemD esse delendam" - Cato
| Attachment | Content-Type | Size |
|---|---|---|
| add_configfile_to_pg_rewind_v2.patch | text/x-patch | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2022-02-25 09:38:36 | Re: BufferAlloc: don't take two simultaneous locks |
| Previous Message | Drouvot, Bertrand | 2022-02-25 09:34:58 | Re: Minimal logical decoding on standbys |