Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Jacob Champion <jchampion(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs
Date: 2023-06-27 06:10:42
Message-ID: 30A45DF9-6B74-4A69-ADB3-19A1DF50E1FA@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 27 Jun 2023, at 07:47, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Jun 26, 2023 at 04:55:47PM -0700, Jacob Champion wrote:
>> I was running the test_pg_dump extension suite, and I got annoyed that
>> I couldn't keep it from deleting its dump artifacts after a successful
>> run. Here's a patch to make use of PG_TEST_NOCLEAN (which currently
>> covers the test cluster's base directory) with the Test::Utils
>> tempdirs too.
>
> I am still +1 in doing that.
>
>> (Looks like this idea was also discussed last year [1]; let me know if
>> I missed any more recent suggestions.)

+1. I think it simply got lost in that thread which had a lot of moving parts
as it was.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-06-27 06:12:43 Add TLI number to name of files generated by pg_waldump --save-fullpage
Previous Message Ashutosh Bapat 2023-06-27 06:00:40 Re: logical decoding and replication of sequences, take 2