From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
Cc: | Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] fix a performance issue with multiple logical-decoding walsenders |
Date: | 2020-01-06 21:43:36 |
Message-ID: | 30846.1578347016@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> On Mon, Jan 6, 2020 at 7:57 PM Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info> wrote:
>> My deepest apologies for the patch being broken, I messed up when transferring
>> it between my computers after altering the comments. The verbatim one attached
>> to this email applies with no issue on current HEAD.
>> The patch regarding PostmasterIsAlive is completely pointless since v12 where
>> the function was rewritten, and was included only to help reproduce the issue
>> on older versions. Back-patching the walsender patch further than v12 would
>> imply back-patching all the machinery introduced for PostmasterIsAlive
>> (9f09529952) or another intrusive change there, a too big risk indeed.
> +1, backpatch to v12 looks sensible.
Pushed with some minor cosmetic fiddling.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2020-01-06 21:53:49 | Re: weird libpq GSSAPI comment |
Previous Message | Alvaro Herrera | 2020-01-06 21:41:45 | Re: weird libpq GSSAPI comment |