Re: weird libpq GSSAPI comment

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robbie Harwood <rharwood(at)redhat(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: weird libpq GSSAPI comment
Date: 2020-01-06 21:53:49
Message-ID: 20200106215349.GL3195@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> On 2020-Jan-06, Stephen Frost wrote:
>
> > > I wonder if part of the confusion might be due to the synonyms we're
> > > using here for "in use". Things seem to be "got running", "set up",
> > > "operating", "negotiated", ... - maybe that's part of the barrier to
> > > understanding?
> >
> > How about something like this?
> >
> > * If GSSAPI Encryption is enabled, then call pg_GSS_have_cred_cache()
> > * which will return true if we can acquire credentials (and give us a
> > * handle to use in conn->gcred), and then send a packet to the server
> > * asking for GSSAPI Encryption (and skip past SSL negotiation and
> > * regular startup below).
>
> WFM. (I'm not sure why you uppercase Encryption, though.)

Ok, great, attached is an actual patch which I'll push soon if there
aren't any other comments.

Thanks!

Stephen

Attachment Content-Type Size
gssapi_encryption_startup_comment_fix_v1.patch text/x-diff 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2020-01-06 22:20:13 Re: psql FETCH_COUNT feature does not work with combined queries
Previous Message Tom Lane 2020-01-06 21:43:36 Re: [PATCH] fix a performance issue with multiple logical-decoding walsenders