Re: log_filename_prefix --> log_filename + strftime()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Ed L(dot)" <pgsql(at)bluepolka(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: log_filename_prefix --> log_filename + strftime()
Date: 2004-08-27 21:52:24
Message-ID: 3079.1093643544@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Ed L." <pgsql(at)bluepolka(dot)net> writes:
> On Friday August 27 2004 1:15, Tom Lane wrote:
>> Yeah, and it would also prevent a risk I now see with your initial
>> patch: if no %, it'll write the same filename each time, which
>> is almost certainly not desired. Works for me.

> I think this turns out to be no big deal either way here as it is for Apache
> either way. Consider if I set my rotation time to 1 hour and my
> log_filename = 'server_log.%a' (server_log.Fri).

But that avoids the problem because you *do* have an escape, and thus
more than one possible logfilename. If we treat no-escape as meaning
a constant filename, there is no rotation possible, other than rotation
through truncation which doesn't seem likely to be useful to anyone.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Ed L. 2004-08-27 22:34:07 Re: log_filename_prefix --> log_filename + strftime()
Previous Message Tom Lane 2004-08-27 21:49:26 Re: log_filename_prefix --> log_filename + strftime()