Re: Extending USE_MODULE_DB to more test suite types

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Extending USE_MODULE_DB to more test suite types
Date: 2019-04-01 17:36:58
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2019-04-01 06:52:13 -0700, Noah Misch wrote:
>> I plan to back-patch the PostgreSQL patch, to combat buildfarm noise. Perhaps
>> someone has test automation that sets USE_MODULE_DB and nonetheless probes the
>> exact database name "pl_regression", but I'm not too worried. The original
>> rationale for USE_MODULE_DB, in commit ad69bd0, was to facilitate pg_upgrade
>> testing. Folks using "make installcheck-world" to populate a cluster for
>> pg_upgrade testing will see additional test coverage, which may cause
>> additional failures. I'm fine with that, too.

> +1 for all of that.

I haven't tested the patch, but also +1 for the idea.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-04-01 18:25:56 pgsql: Unified logging system for command-line programs
Previous Message Tom Lane 2019-04-01 17:34:45 Re: speeding up planning with partitions