Re: Subscription tests vs log_error_verbosity

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Subscription tests vs log_error_verbosity
Date: 2022-06-11 18:52:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I have just got to the bottom of why the new subscription tests
> and have been failing for me - it's
> because my test setup has log_error_verbosity set to 'verbose'. Either
> we should force log_error_verbosity to 'default' for these tests, or we
> should make the regexes we're testing for more forgiving as in the attached.

+1 for the second answer. I don't like forcing parameter settings
that we don't absolutely have to --- it reduces our test coverage.
(Admittedly, changing log_error_verbosity in particular is probably
not giving up much coverage, but as a general principle it's bad.)

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2022-06-11 19:25:48 Re: Non-replayable WAL records through overflows and >MaxAllocSize lengths
Previous Message Andrew Dunstan 2022-06-11 18:08:54 Subscription tests vs log_error_verbosity