Re: new version of PQconnectdb was:(Re: [HACKERS] Determining client_encoding from client locale)

From: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>
To: Andrew Chernow <ac(at)esilo(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: new version of PQconnectdb was:(Re: [HACKERS] Determining client_encoding from client locale)
Date: 2009-09-14 20:19:11
Message-ID: 3073cc9b0909141319n4ff0479dgecacc2740368904f@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 14, 2009 at 2:20 PM, Andrew Chernow <ac(at)esilo(dot)com> wrote:
> Jaime Casanova wrote:
>>
>> On Mon, Sep 14, 2009 at 1:34 PM, Andrew Chernow <ac(at)esilo(dot)com> wrote:
>>>
>>> Jaime Casanova wrote:
>>>>
>>>> i extracted the functions to connect that Heikki put on psql in his
>>>> patch for determining client_encoding from client locale and put it in
>>>> libpq so i follow the PQconnectdbParams(* params[]) approach.
>>
>> [...]
>>>
>>> The below posts agreed on a two argument version of parallel arrays
>>> (keywords, values):
>>>
>>> http://archives.postgresql.org/pgsql-hackers/2009-09/msg00533.php
>>> http://archives.postgresql.org/pgsql-hackers/2009-09/msg00559.php
>>>
>>
>> actually, Tom said: "it's hard to be sure which way is
>> actually more convenient without having tried coding some likely
>> calling scenarios both ways."
>>
>
> Aahhh, correct you are Daniel son :)
>

??? don't understand you ???

>> personally, i think it will cause more problems than solve because you
>> have to be sure your arrays have relationship between them...
>>
>
> A strict relationship exists either way.
>
[...]
>
> IMHO, the struct approach seems like a cleaner solution.
>

i agree

> Any chance of using a term other than "params"?  Maybe "options" or "props"?
>

i don't have any problems with "options"

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-09-14 20:29:15 Re: generic copy options
Previous Message Jaime Casanova 2009-09-14 20:16:10 Re: new version of PQconnectdb was:(Re: [HACKERS] Determining client_encoding from client locale)