Re: BUG: PL/pgSQL FOREACH misparses variable named "slice" with SLICE clause

Leendert Gravendeel <leenderthenk(at)gmail(dot)com> writes:
> When using FOREACH with the SLICE clause, a loop variable named
> `slice` is misinterpreted as the SLICE keyword, causing the statement
> to fail. Renaming the variable to anything else makes the function
> work as expected.

So, um, don't do that. PL/pgSQL will let you use (many of) its keywords
as variable names, but once you declare such a variable, the word will
be taken as a variable reference not as a keyword for the rest of the
block. So what the parser is seeing here is

FOREACH variable variable 1 IN ARRAY variable LOOP

and it naturally doesn't like that. You could also break this
statement by making a variable named "array", for example.
(But not "foreach", "in", or "loop", as those are reserved words.)

Not sure how well this behavior is documented. I think there are
a small number of exceptions, in places where the scanner can know
that the next word must be a keyword, but most unreserved keywords
work this way. The only other thing we could do is make such keywords
fully reserved, which would break legacy code that uses "slice" or
whatever as a variable name without knowledge of the new SLICE syntax.
So we generally try to make newly-added keywords unreserved; this
ambiguity seems the lesser evil.

regards, tom lane