From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Schizophrenic coding in gin_extract_jsonb(_hash) |
Date: | 2014-05-07 16:59:22 |
Message-ID: | 30630.1399481962@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> gin_extract_jsonb recursively extracts all the elements, keys and values
> of any sub-object too, but JB_ROOT_COUNT only counts the top-level elements.
Got it. So if the top level is empty, we can exit early, but otherwise we
use its length * 2 as a guess at how big the output will be; which will
be right if it's an object without further substructure, and otherwise
might need enlargement.
> (I hope this is made a bit more clear in the comments I added in the
> patch I posted this morning)
Didn't read that yet, but will incorporate this info into the jsonb_gin
patch I'm working on.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-05-07 17:08:52 | Re: PGDLLEXPORTing all GUCs? |
Previous Message | Robert Haas | 2014-05-07 16:44:36 | Re: PGDLLEXPORTing all GUCs? |