| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | 蔡梦娟(玊于) <mengjuan(dot)cmj(at)alibaba-inc(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: 回复：Why don't update minimum recovery point in xact_redo_abort |
| Date: | 2021-07-28 03:43:58 |
| Message-ID: | 305e646d-87bb-5ed0-d7f9-558773325f39@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/07/28 1:55, 蔡梦娟(玊于) wrote:
>
> Hi, Fujii
>
> Thanks for your reply.
> And I want to share a patch about the bug with you, I add XLogFlush() in xact_redo_abort() to update the minimum recovery point.
Thanks for the patch! It looks almost the same as the patch I posted upthread.
One diff between them is that you copy-and-pasted the comments for update of
minRecoveryPoint, but instead I just added the comment "See comments ... in
xact_redo_commit()". IMO it's better to avoid putting the same (a bit long)
comments in multiple places so that we can more easily maintain the comments.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2021-07-28 03:44:50 | Re: Why don't update minimum recovery point in xact_redo_abort |
| Previous Message | Jeff Davis | 2021-07-28 03:40:59 | Re: alter table set TABLE ACCESS METHOD |