Re: pgsql: Improve error handling in RemovePgTempFiles().

Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Mon, Jan 8, 2018 at 2:41 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Hearing no comments, I did it the first way.

> It's funny that the two boolean arguments are always opposite.
> They're essentially both saying "top level?".

Yeah. I thought about using a single "bool top_level" argument instead,
but concluded that this way is clearer and potentially more flexible.
There are other places where we have similar cases of flag arguments
that are redundant in current usage, but we leave it like that for
clarity as to what the function's API spec is.

regards, tom lane