Accidental setting of XLogReaderState.private_data ?

From: Antonin Houska <ah(at)cybertec(dot)at>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Accidental setting of XLogReaderState.private_data ?
Date: 2019-04-15 11:51:34
Message-ID: 30563.1555329094@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

StartupDecodingContext() initializes ctx->reader->private_data with ctx, and
it even does so twice. I couldn't find a place in the code where the
(LogicalDecodingContext *) pointer is retrieved from the reader, and a simple
test of logical replication works if the patch below is applied. Thus I assume
that assignment is a thinko, isn't it?

Antonin Houska

Attachment Content-Type Size
xlogreader_private_data.diff text/x-diff 752 bytes


Browse pgsql-hackers by date

  From Date Subject
Next Message Alexey Bashtanov 2019-04-15 11:59:38 Re: log bind parameter values on error
Previous Message Amit Langote 2019-04-15 10:28:30 Re: partitioning performance tests after recent patches